Add MultiPhotonPoseEstimator (from Robot2025) - #88
Merged
Conversation
kcooney
force-pushed
the
kcooney/move-multi-photon-pose-estimator
branch
2 times, most recently
from
October 19, 2025 22:44
a2ba33a to
e158dca
Compare
kcooney
marked this pull request as ready for review
October 19, 2025 22:51
kcooney
force-pushed
the
kcooney/move-multi-photon-pose-estimator
branch
from
October 19, 2025 22:55
e158dca to
948b8d0
Compare
kcooney
force-pushed
the
kcooney/move-multi-photon-pose-estimator
branch
3 times, most recently
from
October 21, 2025 05:11
fed80ad to
2e5011a
Compare
kcooney
force-pushed
the
kcooney/move-multi-photon-pose-estimator
branch
from
October 21, 2025 05:17
2e5011a to
f1502fe
Compare
vdikov
reviewed
Oct 22, 2025
Contributor
Author
|
@vdikov friendly ping |
kcooney
force-pushed
the
kcooney/move-multi-photon-pose-estimator
branch
from
November 18, 2025 05:20
6fa0db5 to
9a8aa46
Compare
cuttestkittensrule
approved these changes
Dec 27, 2025
cuttestkittensrule
left a comment
Collaborator
There was a problem hiding this comment.
lgtm.
We could probably handle some of the TODOs, but this should probably just be merged in
Co-authored-by: cuttestkittensrule <mangoiscute95@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This copies MultiPhotonPoseEstimator from the Robot2025 code, and makes
the following improvements:
update()->processAllUnreadResults()addToSim()->addCamerasToSimulator()setDrivePose()- >publishCameraPosesRelativeTo()PoseEstimateConsumeraddCamera(String, Transform3d, String description)overload(if the camera names describe where they are located, no descriptions
are needed)
addCamerasToSimulator()by allowing callers to add aSupplier<SimCameraProperties>toaddCamera()photonvision/[cameraName]/LatestPose(vs
Vision/[cameraName])The first commit simply copies the code as-is, only changing package
statements.