Skip to content

Add MultiPhotonPoseEstimator (from Robot2025) - #88

Merged
kcooney merged 8 commits into
mainfrom
kcooney/move-multi-photon-pose-estimator
Jan 4, 2026
Merged

Add MultiPhotonPoseEstimator (from Robot2025)#88
kcooney merged 8 commits into
mainfrom
kcooney/move-multi-photon-pose-estimator

Conversation

@kcooney

@kcooney kcooney commented Oct 19, 2025

Copy link
Copy Markdown
Contributor

This copies MultiPhotonPoseEstimator from the Robot2025 code, and makes
the following improvements:

  1. Improve Javadoc
  2. Rename methods for clarity
    • update() -> processAllUnreadResults()
    • addToSim() -> addCamerasToSimulator()
    • setDrivePose() - > publishCameraPosesRelativeTo()
  3. Introduce PoseEstimateConsumer
  4. Simplify the API
    • Remove addCamera(String, Transform3d, String description) overload
      (if the camera names describe where they are located, no descriptions
      are needed)
    • Simplify API of addCamerasToSimulator() by allowing callers to add a
      Supplier<SimCameraProperties> to addCamera()
    • Publish additional topics under photonvision/[cameraName]/LatestPose
      (vs Vision/[cameraName])

The first commit simply copies the code as-is, only changing package
statements.

@kcooney
kcooney force-pushed the kcooney/move-multi-photon-pose-estimator branch 2 times, most recently from a2ba33a to e158dca Compare October 19, 2025 22:44
@kcooney
kcooney marked this pull request as ready for review October 19, 2025 22:51
@kcooney
kcooney force-pushed the kcooney/move-multi-photon-pose-estimator branch from e158dca to 948b8d0 Compare October 19, 2025 22:55
@kcooney
kcooney force-pushed the kcooney/move-multi-photon-pose-estimator branch 3 times, most recently from fed80ad to 2e5011a Compare October 21, 2025 05:11
@kcooney
kcooney force-pushed the kcooney/move-multi-photon-pose-estimator branch from 2e5011a to f1502fe Compare October 21, 2025 05:17
Comment thread vision/src/main/java/com/team2813/lib2813/vision/MultiPhotonPoseEstimator.java Outdated
Comment thread vision/src/main/java/com/team2813/lib2813/vision/MultiPhotonPoseEstimator.java Outdated
@kcooney

kcooney commented Nov 6, 2025

Copy link
Copy Markdown
Contributor Author

@vdikov friendly ping

@kcooney
kcooney force-pushed the kcooney/move-multi-photon-pose-estimator branch from 6fa0db5 to 9a8aa46 Compare November 18, 2025 05:20

@cuttestkittensrule cuttestkittensrule left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.
We could probably handle some of the TODOs, but this should probably just be merged in

Comment thread vision/src/main/java/com/team2813/lib2813/vision/MultiPhotonPoseEstimator.java Outdated
Comment thread vision/src/main/java/com/team2813/lib2813/vision/MultiPhotonPoseEstimator.java Outdated
Co-authored-by: cuttestkittensrule <mangoiscute95@gmail.com>
@kcooney
kcooney merged commit 20c4139 into main Jan 4, 2026
1 of 2 checks passed
@kcooney
kcooney deleted the kcooney/move-multi-photon-pose-estimator branch January 4, 2026 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants